Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A FailureApp should know its failure message #97

Merged
merged 1 commit into from Aug 15, 2014
Merged

A FailureApp should know its failure message #97

merged 1 commit into from Aug 15, 2014

Conversation

betesh
Copy link
Contributor

@betesh betesh commented Aug 15, 2014

In my humble opinion, a FailureApp should know why someone woke it up.

For instance, in this example in devise: https://github.com/plataformatec/devise/blob/v3.3.0/lib/devise/strategies/database_authenticatable.rb#L17, it seems to be that :not_found_in_database is a useful piece of information that the FailureApp should have access to.

@josevalim
Copy link
Contributor

:shipit:

hassox pushed a commit that referenced this pull request Aug 15, 2014
A FailureApp should know its failure message
@hassox hassox merged commit 74162f2 into wardencommunity:master Aug 15, 2014
@mmzoo
Copy link

mmzoo commented Aug 20, 2014

Ah, thank you so much. This caused me some debugging headache today :) Looking forward to having this available via rubygems as well.

@betesh
Copy link
Contributor Author

betesh commented Aug 20, 2014

@josevalim What does the squirrel mean?

@mmzoo
Copy link

mmzoo commented Aug 20, 2014

@betesh google "ship it squirrel" :)

@betesh
Copy link
Contributor Author

betesh commented Aug 20, 2014

As in http://www.geoffreywiseman.ca/blog/2013/03/15/shipit-update-plan/ ? So if you use the shipit squirrel in an issue comment, that means merge it and publish a new gem, i.e. ship the upgrade immediately?

@mmzoo
Copy link

mmzoo commented Aug 20, 2014

@betesh Well, primarily it means 'alright, approved, this is good to go'. I don't know about wardens policy for when it is okay to publish a new version to rubygems. Other gem-maintainers usually wait for a few issues to be solved and when they feel it's time to launch a new version, it will be pushed to rubygems. So I expect that to happen in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants