Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backet \ detection window for pattern analytic unit #83

Closed
glitch4347 opened this issue Dec 24, 2021 · 4 comments · Fixed by #85
Closed

backet \ detection window for pattern analytic unit #83

glitch4347 opened this issue Dec 24, 2021 · 4 comments · Fixed by #85
Milestone

Comments

@glitch4347
Copy link
Contributor

Only threshold can work without "window": it takes one datapoint from metric and checks if it falls over threshold. In case of pattern and anomaly detector it's impossible to make detection on one datapoint, so we need to define the size of the window which could be used for pattern / anomaly detection. Supposedly, we need to

  1. implement method get_detection_window from AnalyticUnit trait.
  2. fill bucket in DetectionRunner::run with of size get_detection_window
  3. run detection on bucket
@glitch4347
Copy link
Contributor Author

This task is about pattern analytic unit only, anomaly unit implementation in #84

@glitch4347
Copy link
Contributor Author

the change should not (obviously) brake threshold detector

@glitch4347
Copy link
Contributor Author

glitch4347 commented Dec 24, 2021

also this logic on window should work with DETECTION_STEP -- we need update the window periodically. It's a bit not obvious where we should take DETECTION_STEP: from metric service or it should be a new method in AnalyticUnit trait

@rozetko what do you think

(for now we agreed to take DETECTION_STEP from metric_service)

@glitch4347
Copy link
Contributor Author

I also noticed that in method DetectionRunner::run field t_from and t_to are not updated, so DetectionRunner doesn't work even for thresholds :)

glitch4347 added a commit that referenced this issue Dec 25, 2021
…n-analytic-unit-#83

Bucket detection window for pattern analytic unit #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant