Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bucket detection window for pattern analytic unit #83 #85

Merged
merged 4 commits into from Dec 25, 2021
Merged

Bucket detection window for pattern analytic unit #83 #85

merged 4 commits into from Dec 25, 2021

Conversation

glitch4347
Copy link
Contributor

@glitch4347 glitch4347 commented Dec 24, 2021 •
edited

Closes #83

Changes

  • MetricService now has get_detection_step method which return 10 -- it's a hack
  • PatternAnalyticUnit returns avg_pattern_length in get_detection_window -- it's also not 100% right cuz there used unwrap and formally learning results can be None

Notes

This PR doesn't really introduce bucket and query from metrics_service used to get data for detection

@glitch4347 glitch4347 changed the title Backet detection window for pattern analytic unit #83 Bucket detection window for pattern analytic unit #83 Dec 24, 2021
@glitch4347 glitch4347 merged commit 4f66b59 into main Dec 25, 2021
@rozetko rozetko deleted the backet-detection-window-for-pattern-analytic-unit-#83 branch December 27, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozetko rozetko rozetko approved these changes

Assignees

@rozetko rozetko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

backet \ detection window for pattern analytic unit
2 participants
@glitch4347 @rozetko