Bring back sandboxes #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasufell
commented
Jun 10, 2024
| @@ -339,7 +340,8 @@ mainWorker args = do | |||
| CommandHelp help -> printGlobalHelp help | |||
| CommandList opts -> printOptionsList opts | |||
| CommandErrors errs -> printErrors errs | |||
| CommandReadyToGo (globalFlags, commandParse) -> | |||
| CommandReadyToGo (globalFlags', commandParse) -> do | |||
| globalFlags <- CmdSandbox.updateGlobalFlags Nothing globalFlags' | |||
There was a problem hiding this comment.
Here we inject the --store-dir=foo thing for all commands.
hasufell
commented
Jun 10, 2024
Comment on lines
+747
to
+753
| isSandbox <- Sandbox.isSandbox Nothing | ||
| let merged = savedClientInstallFlags savedConfig `mappend` existingClientInstallFlags | ||
| if isSandbox | ||
| then do | ||
| cwd <- getCurrentDirectory | ||
| pure $ merged { cinstEnvironmentPath = Flag cwd } | ||
| else pure $ merged |
There was a problem hiding this comment.
Here we check during cabal install whether we're in a sanbdox and if so pass the --package-env=. flag, creating a ghc environment file.
It seems the env file already acts as a "world file"... it will (except for base) only contain the targets we specified via cabal install --lib. So I'm not sure it's necessary to play tricks with recreation of the env file to allow new resolutions.
Instead, I think it is reasonable to have users specify multiple targets to avoid resolution issues, such as cabal install --lib text attoparsec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.