fix(app): setup was failing with "Error: Branch undefined not found" (#…

…969)
hasundue · Oct 31, 2022 · 695b261 · 695b261
2 parents ba4fc06 + b30a8df
commit 695b261
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/app/webhooks.ts b/app/webhooks.ts
@@ -92,7 +92,7 @@ const associated = (context: Context) => {
 };
 
 const isDenoProject = async (github: GitHubClient) => {
-  const tree = await github.getTree();
+  const tree = await github.getTree(await github.defaultBranch());
   const paths = tree.map((blob) => blob.path!);
 
   const targets = ["deno.json", "deno.jsonc"];

diff --git a/mod/octokit.ts b/mod/octokit.ts
@@ -97,20 +97,20 @@ export class GitHubClient {
     return data.default_branch;
   }
 
-  async getBranch(branch?: string) {
+  async getBranch(branch: string) {
     const { owner, repo } = this.ensureRepository();
     try {
       const { data } = await this.octokit.request(
         "GET /repos/{owner}/{repo}/branches/{branch}",
-        { owner, repo, branch: (branch ?? await this.defaultBranch()) },
+        { owner, repo, branch },
       );
       return data;
     } catch {
       return null;
     }
   }
 
-  async getTree(branch?: string) {
+  async getTree(branch: string) {
     const { owner, repo } = this.ensureRepository();
 
     const head = await this.getBranch(branch);