Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete comment #8

Merged
merged 6 commits into from
Jul 21, 2023
Merged

feat: delete comment #8

merged 6 commits into from
Jul 21, 2023

Conversation

robertjdominguez
Copy link
Collaborator

@robertjdominguez robertjdominguez commented Jul 20, 2023

This PR adds the ability to delete comments. An updated example is provided in the README.

One modification to the existing code: as delete is a reserved keyword, I opted in modifying the modes' input names to, as one example, appendComment instead of append.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@scriptnull scriptnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR Rob 🙏

I took a look at all the files and left two comments. Additionally a small request: could you replace v2.1.0 version number in README.md file to v2.2.0 because I will be release v2.2.0 immediately after the merge of this PR :)

@robertjdominguez
Copy link
Collaborator Author

Done, @scriptnull — thanks! 🔥

Copy link
Member

@scriptnull scriptnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ❤️

@scriptnull scriptnull merged commit 1055836 into main Jul 21, 2023
1 check passed
@scriptnull scriptnull deleted the rob/feat/delete-comment branch July 21, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants