Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade docker cli to 18.06 #99

Merged
merged 3 commits into from
Nov 3, 2018
Merged

Upgrade docker cli to 18.06 #99

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
790db4b
Enable multi-staged builds
Oct 26, 2018
465f691
Update location of where to download Docker image
Oct 30, 2018
02fe405
Upgrade to docker-18.06.1-ce tar archive
Oct 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions build/gitkubed/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ MAINTAINER tiru@hasura.io
# Install openssh server
RUN apt-get update \
&& apt-get install -y upx-ucl binutils curl openssh-server git jq \
&& curl -o /tmp/docker-1.12 'https://get.docker.com/builds/Linux/x86_64/docker-1.12.6.tgz' \
&& tar -xf /tmp/docker-1.12 -C /tmp \
&& curl -o /tmp/docker-18.06 'https://download.docker.com/linux/static/stable/x86_64/docker-18.06.1-ce.tgz' \
&& tar -xf /tmp/docker-18.06 -C /tmp \
&& mv /tmp/docker/docker /bin/docker \
Copy link
Collaborator

@tirumaraiselvan tirumaraiselvan Nov 2, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the server isn't upgrading even after changing the potentially buggy L9. I changed L9 to cp /tmp/docker/* /bin/ to copy all the binaries including dockerd yet:

root@gitkubed-6cf7744876-jwg2w:/# docker version
Client:
 Version:           18.06.1-ce
 API version:       1.27 (downgraded from 1.38)
 Go version:        go1.10.3
 Git commit:        e68fc7a
 Built:             Tue Aug 21 17:20:43 2018
 OS/Arch:           linux/amd64
 Experimental:      false

Server:
 Engine:
  Version:          17.03.2-ce
  API version:      1.27 (minimum version 1.12)
  Go version:       go1.9.2
  Git commit:       f5ec1e2
  Built:            Fri Aug 10 11:50:21 2018
  OS/Arch:          linux/amd64
  Experimental:     false

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the container just taking to the host daemon (through a bind-mounted /var/run/docker.sock? The Dockerfile only installs the docker cli, not the daemon

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Completely missed it :) Hmm, so no way to solve this if cloud providers don't give us newer docker.

&& rm -rf /tmp/docker-1.12 /tmp/docker \
&& rm -rf /tmp/docker-18.06 /tmp/docker \
&& strip --strip-unneeded /bin/docker \
&& chmod a+x /bin/docker \
&& upx /bin/docker \
Expand Down