Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxy all requests from console through cli #1440

Closed
shahidhk opened this issue Jan 23, 2019 · 4 comments
Closed

proxy all requests from console through cli #1440

shahidhk opened this issue Jan 23, 2019 · 4 comments
Labels
c/cli Related to CLI c/console Related to console e/intermediate can be wrapped up in a week p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints s/wip Status: This issue is a work in progress

Comments

@shahidhk
Copy link
Member

For CLI hosted console, only migration requests are procured through CLI. To host this console on a server, all requests should go through CLI protected by the access key.
@shahidhk shahidhk added c/console Related to console c/cli Related to CLI labels Jan 23, 2019
@thedeeno
Copy link

Very handy in dockerized dev environments where the ui and cli see different addresses for the graphql-engine. This change would make it so the host browser only needs to care about 1 of those addresses.

@shahidhk shahidhk added p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints e/intermediate can be wrapped up in a week labels Jan 30, 2019
@shahidhk shahidhk mentioned this issue Feb 4, 2019
Closed
@shahidhk shahidhk added this to the v1.0.0-alpha39 milestone Feb 4, 2019
@dsandip
Copy link
Member

dsandip commented Feb 4, 2019

cc: @danielcompton

@shahidhk shahidhk modified the milestones: v1.0.0-alpha39, v1.0.0-alpha40 Feb 28, 2019
@shahidhk shahidhk mentioned this issue Mar 11, 2019
Closed
@arvi3411301 arvi3411301 self-assigned this Mar 14, 2019
@arvi3411301 arvi3411301 added the s/wip Status: This issue is a work in progress label Mar 14, 2019
arvi3411301 added a commit to arvi3411301/graphql-engine that referenced this issue Mar 14, 2019
@arvi3411301
add proxy api group to proxy requests from console to server, close h…
9b20afa 
…asura#1440
@arvi3411301 arvi3411301 mentioned this issue Mar 14, 2019
Closed
@shahidhk
Copy link
Member Author 

hasura console --endpoint http://graphql-engine:8080 --address 0.0.0.0 --console-port 8080 --api-port 8081 --api-external-host https://my-hasura-cli-host.com

@shahidhk shahidhk removed their assignment Mar 19, 2019
@rikinsk-zz rikinsk-zz removed this from the v1.0.0-alpha42 milestone Jun 6, 2019
@shahidhk
Copy link
Member Author

Closed in favor of #2824 which will allow running CLI on docker containers or elsewhere.

@peterldowns peterldowns mentioned this issue Oct 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/cli Related to CLI c/console Related to console e/intermediate can be wrapped up in a week p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints s/wip Status: This issue is a work in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@thedeeno @rikinsk-zz @shahidhk @arvi3411301 @dsandip