Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Ability to flag insert as a migration #1766

Closed
sebastianmacias opened this issue Mar 13, 2019 · 6 comments · Fixed by #4993
Closed

Feature request: Ability to flag insert as a migration #1766

sebastianmacias opened this issue Mar 13, 2019 · 6 comments · Fixed by #4993
Assignees
Labels
c/console Related to console e/easy can be wrapped up in a couple of days k/enhancement New feature or improve an existing feature p/high candidate for being included in the upcoming sprint s/wip Status: This issue is a work in progress

Comments

@sebastianmacias
Copy link

sebastianmacias commented Mar 13, 2019

Currently under "Raw SQL" there is an option to flag a SQL statement (including inserts) as a migration so the migration files are automatically created.

This is very helpful but I think being able to flag a new record to be inserted as a migration using the web based CLI would be even more helpful.

The UI could look something like this:

This is a migration

@0x777 0x777 added c/console Related to console k/ideas Discuss new ideas / pre-proposals / roadmap labels Mar 15, 2019
@michaelhayman
Copy link

Seconded, would have come in handy today)

@sebastianmacias
Copy link
Author

I think having the ability to flag a migration when editing a record using the console would be a really helpful feature to have as well. It would make loading "fixtures" or initial data very simple.

@rikinsk-zz rikinsk-zz added k/enhancement New feature or improve an existing feature p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints and removed k/enhancement New feature or improve an existing feature p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints labels Apr 15, 2019
@dsandip dsandip added e/intermediate can be wrapped up in a week k/enhancement New feature or improve an existing feature p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints and removed k/ideas Discuss new ideas / pre-proposals / roadmap e/intermediate can be wrapped up in a week labels May 13, 2019
@tmattio
Copy link

tmattio commented May 21, 2019

I would find it very useful as well!

@earslap
Copy link

earslap commented Jul 3, 2019

I would also find this useful. Especially since ENUMs are not yet supported, if you use a foreign table contents as "type" in another table, the rows in the foreign table essentially become part of your schema due to the constraints between the two. So those inserts to the foreign table belong to migrations, and it would be nice to be able to flag them as such.

@rikinsk-zz rikinsk-zz added p/high candidate for being included in the upcoming sprint and removed p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints labels Jul 3, 2019
@rikinsk-zz rikinsk-zz added e/easy can be wrapped up in a couple of days and removed e/easy can be wrapped up in a couple of days labels Jul 10, 2019
@rikinsk-zz rikinsk-zz removed their assignment Jul 10, 2019
@rikinsk-zz rikinsk-zz added p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints and removed p/high candidate for being included in the upcoming sprint labels Jul 23, 2019
@rikinsk rikinsk added p/high candidate for being included in the upcoming sprint and removed p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints labels Sep 6, 2019
@wawhal wawhal added the s/wip Status: This issue is a work in progress label Oct 10, 2019
@wawhal
Copy link
Contributor

wawhal commented Oct 10, 2019

This feature is blocked on #3082

This is because, the complete row details (including auto generated values) are required to generate down migrations. Once the CLI supports generating migrations without executing them, the console can first insert the value, get the row details and then create up and down migrations.

@wawhal
Copy link
Contributor

wawhal commented Mar 7, 2020

@shahidhk @arvi3411301 @scriptonist can y'all get #3082 done ASAP so that we can start fixing this issue? It's been open for a while and a lot of people seem to want it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console Related to console e/easy can be wrapped up in a couple of days k/enhancement New feature or improve an existing feature p/high candidate for being included in the upcoming sprint s/wip Status: This issue is a work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants