send error over websocket when query validation fails (fix #1790) #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x777
approved these changes
Mar 17, 2019
|
Review app https://hge-ci-pull-1792.herokuapp.com is deleted |
|
Review app for commit 3b9f035 deployed to Heroku: https://hge-ci-pull-1792.herokuapp.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Over websocket transport, in some cases of query validation errors, connection_error was thrown (which is for protocol errors) instead of error.
Affected components
Related Issues
#1790
Solution and Design
Steps to test and verify
Simple fix to use the correct function to send GQL_ERROR and not GQL_CONNECTION_ERROR.
Limitations, known bugs & workarounds