don't send the request to the client on HTTP throw

[tirumaraiselvan]

Description

Before:

{
  "errors": [
    {
      "extensions": {
        "path": "$",
        "code": "unexpected"
      },
      "message": "HttpExceptionRequest Request {\n  host                 = \"localhost\"\n  port                 = 4000\n  secure               = False\n  requestHeaders       = [(\"Content-Type\",\"application/json\"),(\"User-Agent\",\"hasura-graphql-engine/remote-schema-logging-b2b33755-dirty\"),(\"SECRET_HEADER\",\"very_secret_hahahha\"),(\"x-hasura-role\",\"user\")]\n  path                 = \"/\"\n  queryString          = \"\"\n  method               = \"POST\"\n  proxy                = Nothing\n  rawBody              = False\n  redirectCount        = 10\n  responseTimeout      = ResponseTimeoutDefault\n  requestVersion       = HTTP/1.1\n}\n (ConnectionFailure Network.Socket.connect: <socket: 35>: does not exist (Connection refused))"
    }
  ]
}

After:

{
  "errors": [
    {
      "extensions": {
        "path": "$",
        "code": "unexpected"
      },
      "message": "ConnectionFailure Network.Socket.connect: <socket: 36>: does not exist (Connection refused)"
    }
  ]
}

Affected components

• Server

Related Issues

Solution and Design

HTTPException has two parts: Request and ExceptionContent. We now return only the ExceptionContent.

Steps to test and verify

Limitations, known bugs & workarounds

[netlify]

Deploy preview for hasura-docs ready!

Built with commit 262e248

https://deploy-preview-2738--hasura-docs.netlify.com

[hasura-bot]

Review app for commit 8bc9baf deployed to Heroku: https://hge-ci-pull-2738.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2738-8bc9bafa

[ecthiender]

LGTM

[hasura-bot]

Review app for commit 262e248 deployed to Heroku: https://hge-ci-pull-2738.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2738-262e2482

[hasura-bot]

Review app https://hge-ci-pull-2738.herokuapp.com is deleted