Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update enums docs #2813

Merged
merged 14 commits into from Sep 3, 2019
Merged

update enums docs #2813

merged 14 commits into from Sep 3, 2019

Conversation

rikinsk
Copy link
Member

@rikinsk rikinsk commented Sep 2, 2019 •
edited

Description

  • add structure to the page for easier referencing & readability
  • attempted to make each section individually sufficient to help readability when referenced
  • add PG enum to enum table creation note
  • add console flows for the set as enum
  • add migrations caveat section

Affected components

  • Docs

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk rikinsk requested a review from dsandip September 2, 2019 07:06
@netlify
Copy link

netlify bot commented Sep 2, 2019 •
edited

Deploy preview for hasura-docs ready!

Built with commit 6c62d6c

https://deploy-preview-2813--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit e27edfd deployed to Heroku: https://hge-ci-pull-2813.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2813-e27edfda

@hasura-bot
Copy link
Contributor

Review app for commit bbd22ef deployed to Heroku: https://hge-ci-pull-2813.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2813-bbd22efd

@hasura-bot
Copy link
Contributor

Review app for commit 05992ac deployed to Heroku: https://hge-ci-pull-2813.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2813-05992ac7

marionschleifer
marionschleifer previously approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@marionschleifer marionschleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@hasura-bot
Copy link
Contributor

Review app for commit 535b7fb deployed to Heroku: https://hge-ci-pull-2813.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2813-535b7fb6

marionschleifer
marionschleifer requested changes Sep 3, 2019
View reviewed changes
docs/graphql/manual/schema/enums.rst Outdated Show resolved Hide resolved
docs/graphql/manual/schema/enums.rst Outdated Show resolved Hide resolved
@hasura-bot
Copy link
Contributor

Review app for commit 6c62d6c deployed to Heroku: https://hge-ci-pull-2813.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2813-6c62d6cc

@rikinsk rikinsk merged commit 47fb329 into hasura:master Sep 3, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-2813.herokuapp.com is deleted

@rikinsk rikinsk deleted the docs-enums branch September 3, 2019 14:17
@rikinsk rikinsk added the c/docs Related to docs label Sep 4, 2019
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@rikinsk @polRk
update enums docs (hasura#2813)
bc44db5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marionschleifer marionschleifer marionschleifer approved these changes

@dsandip dsandip Awaiting requested review from dsandip

Assignees
No one assigned
Labels
c/docs Related to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rikinsk @hasura-bot @marionschleifer