Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli(fix): better error handling on non-json api responses (clos… #3104

Merged
merged 2 commits into from Dec 27, 2019
Merged

cli(fix): better error handling on non-json api responses (clos… #3104

merged 2 commits into from Dec 27, 2019

Conversation

rv404674
Copy link
Contributor

@rv404674 rv404674 commented Oct 12, 2019 •
edited

Description

Affected components

  • CLI

Related Issues

#2954

Solution and Design

It was sendv1Query() function that was being called when a post request for migration was being made. Now a custom error message is being sent, when unmarshalling of body is failing.

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @rv404674, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link

netlify bot commented Oct 12, 2019 •
edited

Deploy preview for hasura-docs ready!

Built with commit bbfb9d7

https://deploy-preview-3104--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit bc9ef9d deployed to Heroku: https://hge-ci-pull-3104.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3104-bc9ef9d4

@marionschleifer marionschleifer added the c/community Related to community content label Oct 12, 2019
@rahulverma283 @rv404674
Returned a proper error statement if unmarshalling of reponse body fa…
0427736 
…iled.

It was sendv1Query() function that was being called when a post request for migration was being made. Now a custom error message is being sent, when unmarshalling of body is failing.
@rv404674 rv404674 changed the title WIP: Did better api handling on the CLI (close #2954) Did better api handling on the CLI (close #2954) Oct 13, 2019
@rv404674 rv404674 marked this pull request as ready for review October 13, 2019 23:38
@rv404674
Copy link
Contributor Author

rv404674 commented Oct 13, 2019 •
edited

@marionschleifer . Hi marion. I have signed CLA agreement 3-4 times. But still it is showing CLA not signed. What should I do??. Clicking CLA link is showing "You have signed the CLA for hasura/graphql-engine", but still I am getting CLA not signed yet.

@hasura-bot
Copy link
Contributor

Review app for commit 0427736 deployed to Heroku: https://hge-ci-pull-3104.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3104-0427736a

@rv404674
Copy link
Contributor Author

@shahidhk Can you please review it once you get some time??. Thanks. :)

@marionschleifer
Copy link
Contributor

@rv404674 Don't worry about the CLA issue. We'll fix it manually once @shahidhk is done reviewing 🙂

@marionschleifer marionschleifer added the c/cli Related to CLI label Oct 19, 2019
@tirumaraiselvan tirumaraiselvan mentioned this pull request Dec 10, 2019
Closed
@marionschleifer marionschleifer added community-contrib 🙏🏽 and removed c/community Related to community content labels Dec 24, 2019
@arvi3411301 arvi3411301 self-requested a review December 27, 2019 09:43
@shahidhk shahidhk changed the title Did better api handling on the CLI (close #2954) cli(fix): better api error handling on non-json responses (close #2954) Dec 27, 2019
@shahidhk shahidhk changed the title cli(fix): better api error handling on non-json responses (close #2954) cli(fix): better error handling on non-json api responses (close #2954) Dec 27, 2019
@hasura-bot
Copy link
Contributor

Review app for commit bbfb9d7 deployed to Heroku: https://hge-ci-pull-3104.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3104-bbfb9d7c

@shahidhk shahidhk changed the title cli(fix): better error handling on non-json api responses (close #2954) cli(fix): better error handling on non-json api responses (clos… Dec 27, 2019
@shahidhk shahidhk merged commit c6ab101 into hasura:master Dec 27, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3104.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

GIF

Awesome work @rv404674! All of us at Hasura ❤️ what you did.

Thanks again 🤗

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@rv404674 @rahulverma283
@shahidhk @polRk
cli(fix): better error handling on non-json api responses (clos… (has…
6ffef86 
…ura#3104)

Co-authored-by: Rahul Verma <51950008+rahulverma283@users.noreply.github.com>
Co-authored-by: Shahidh K Muhammed <muhammedshahid.k@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahidhk shahidhk shahidhk approved these changes

@arvi3411301 arvi3411301 arvi3411301 approved these changes

Assignees
No one assigned
Labels
c/cli Related to CLI community-contrib 🙏🏽
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rv404674 @hasura-bot @CLAassistant @marionschleifer @shahidhk @arvi3411301 @rahulverma283