Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sql-page): cursor pointer on track and cascade -> close #3276 #3364

Merged
merged 3 commits into from Nov 19, 2019
Merged

fix(sql-page): cursor pointer on track and cascade -> close #3276 #3364

merged 3 commits into from Nov 19, 2019

Conversation

ShahAnuj2610
Copy link
Contributor

@ShahAnuj2610 ShahAnuj2610 commented Nov 15, 2019 •
edited

Affected components

  • Console

Related Issues

fixes #3276

Solution and Design

use style cursorPointer

Previous behaviour:

hovering over checkbox shows a normal pointer

Current behaviour:

hovering over checkbox shows a cursor pointer

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @ShahAnuj2610, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Nov 15, 2019 •
edited

Deploy preview for hasura-docs ready!

Built with commit 4fbeab6

https://deploy-preview-3364--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit faa9f15 deployed to Heroku: https://hge-ci-pull-3364.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3364-faa9f15f

@hasura-bot
Copy link
Contributor

Review app for commit dd8438e deployed to Heroku: https://hge-ci-pull-3364.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3364-dd8438eb

@rikinsk rikinsk merged commit d2046d8 into hasura:master Nov 19, 2019
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

GIF

Awesome work @ShahAnuj2610! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3364.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

Review app for commit 4fbeab6 deployed to Heroku: https://hge-ci-pull-3364.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3364-4fbeab67

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@ShahAnuj2610 @polRk
make cursor pointer on track and cascade checkboxes in console RawSQL (…
b97fd5e 
…close hasura#3276) (hasura#3364)
hasura-bot pushed a commit that referenced this pull request Mar 7, 2022
@robx @hasura-bot
pro, multitenant: remove broken process-level ekg stats
437ef45 
Fixes #3364.

This removes code that's only there to collect some metrics that were apparently never collected in production anyway, as confirmed by this slack discussion: https://hasurahq.slack.com/archives/CTRL7L1PZ/p1645547435034329

> We don't ever ingest these statsd metrics to lux, nor on HC AFAIK.

We're keeping the command line options for the moment to allow lux time to stop passing them.

PR-URL: hasura/graphql-engine-mono#3365
GitOrigin-RevId: bc6aa2c18a7d3eb0779ed17494662df5b7b54a76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikinsk rikinsk rikinsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make cursor pointer on "track" and "cascade" checkboxes on sql page
4 participants
@ShahAnuj2610 @hasura-bot @CLAassistant @rikinsk