Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relay fixes #5013

Merged
merged 12 commits into from Jun 16, 2020
Merged

relay fixes #5013

merged 12 commits into from Jun 16, 2020

Conversation

rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented Jun 8, 2020 •
edited

Description

More tests, bug fixes and reduce node id string length.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Change log not required since these changes don't affect any stable release.

Affected components

  • Server
  • Tests

Related Issues

Fix #5020, #5037, #5046

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated

Breaking changes

  • No Breaking changes
  • There are breaking changes

@rakeshkky rakeshkky added c/server Related to server no-changelog-required c/relay Related to GraphQL Relay labels Jun 8, 2020
@rakeshkky rakeshkky self-assigned this Jun 8, 2020
@rakeshkky rakeshkky changed the title tiny fixes for relay validate required session variables for relay queries Jun 8, 2020
@rakeshkky rakeshkky changed the title validate required session variables for relay queries relay fixes Jun 9, 2020
@netlify
Copy link

netlify bot commented Jun 10, 2020 •
edited

Deploy preview for hasura-docs ready!

Built with commit 88db45f

https://deploy-preview-5013--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

Review app for commit f7fd364 deployed to Heroku: https://hge-ci-pull-5013.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5013-f7fd3648

This was referenced Jun 10, 2020
Closed
Merged
@hasura-bot
Copy link
Contributor

Review app for commit a75e9eb deployed to Heroku: https://hge-ci-pull-5013.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5013-a75e9ebe

@hasura-bot
Copy link
Contributor

Review app for commit 03932a8 deployed to Heroku: https://hge-ci-pull-5013.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5013-03932a8c

@hasura-bot
Copy link
Contributor

Review app for commit c7bc42b deployed to Heroku: https://hge-ci-pull-5013.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5013-c7bc42b6

@rakeshkky rakeshkky mentioned this pull request Jun 10, 2020
Closed
@rakeshkky rakeshkky added this to the v1.3 milestone Jun 10, 2020
This was linked to issues Jun 10, 2020
Relay hash id size #5037
Closed
Remote joins metadata import failing. Types must be same. #5046
Closed
@rakeshkky rakeshkky marked this pull request as ready for review June 10, 2020 13:39
@rakeshkky rakeshkky requested a review from 0x777 June 10, 2020 13:39
@hasura-bot
Copy link
Contributor

Review app for commit 88db45f deployed to Heroku: https://hge-ci-pull-5013.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5013-88db45f4

@hasura-bot
Copy link
Contributor

Review app for commit ec86246 deployed to Heroku: https://hge-ci-pull-5013.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5013-ec862469

@tirumaraiselvan tirumaraiselvan mentioned this pull request Jun 13, 2020
Closed
@sanderhahn sanderhahn mentioned this pull request Jun 15, 2020
Closed
@hasura-bot
Copy link
Contributor

Review app for commit 8a7a7f6 deployed to Heroku: https://hge-ci-pull-5013.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5013-8a7a7f6c

@rakeshkky rakeshkky requested a review from 0x777 June 16, 2020 10:48
@hasura-bot
Copy link
Contributor

Review app for commit 9583379 deployed to Heroku: https://hge-ci-pull-5013.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5013-95833795

@rakeshkky rakeshkky requested a review from 0x777 June 16, 2020 11:58
@hasura-bot
Copy link
Contributor

Review app for commit 2581cb0 deployed to Heroku: https://hge-ci-pull-5013.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5013-2581cb0e

@hasura-bot
Copy link
Contributor

Review app for commit c733863 deployed to Heroku: https://hge-ci-pull-5013.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5013-c733863c

@0x777 0x777 merged commit 4e229dc into hasura:master Jun 16, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-5013.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

Review app for commit 03a37a4 deployed to Heroku: https://hge-ci-pull-5013.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5013-03a37a47

@PedroBern PedroBern mentioned this pull request Aug 27, 2020
Open
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@rakeshkky @scriptonist
@0x777 @stevefan1999-personal
relay fixes (hasura#5013)
7cdca7b 
* fix relay introspection failing if any views exist, fix hasura#5020

* reduce base64 encoded node id length, close hasura#5037

* make node field type non-nullable in an edge

* more relay tests with permissions & complete restructure of test yaml files

Co-authored-by: Aravind <aravindkp@outlook.in>
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x777 0x777 0x777 approved these changes

Assignees

@rakeshkky rakeshkky

Labels
c/relay Related to GraphQL Relay c/server Related to server no-changelog-required
Projects
None yet
Milestone
v1.3
4 participants
@rakeshkky @hasura-bot @0x777 @scriptonist