console: allow user to cascade Postgres dependencies when dropping Postgres objects (close #5109) #5248

soorajshankar · 2020-07-01T08:36:10Z

Description

This PR adds a user prompt when the user gets postgress error dependent_objects_still_exist-2BP01

Changelog

CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

Console

Related Issues

closes #5109

Solution and Design

This PR will add an on error listener at makeMigrationCall which makes sure that

if there is a Postgres dependency error, the user will get a prompt that allows the user to make a decision whether to continue the operation with cascading dependent modules or to cancel the operation.

Steps to test and verify

create a 2 tables which have foreign key relationships.
Try deleting the table where the foreign key relationship.
check the network response, if this contains postgress error '2BP01' now the user will see an error prompt.
click on continue, now check the network query.
compare with the previous query, this should contain the cascade in the up query.

Limitations, known bugs & workarounds

possibility of inconsistent down migration after the cascade operations.

Does this PR add a new Metadata feature?

No

GraphQL

No new GraphQL schema is generated

Breaking changes

No Breaking changes

netlify · 2020-07-01T08:37:55Z

Deploy preview for hasura-docs ready!

Built with commit 3ed8d1e

https://deploy-preview-5248--hasura-docs.netlify.app

hasura-bot · 2020-07-01T08:53:08Z

Review app for commit 2827931 deployed to Heroku: https://hge-ci-pull-5248.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5248-28279312

console/src/components/Services/Data/utils.js

Co-authored-by: Aleksandra Sikora <aleksandra@hasura.io>

…o feat/pg_cascade_prompt

…nkar/graphql-engine into feat/pg_cascade_prompt

hasura-bot · 2020-07-15T07:42:07Z

Review app for commit 30ded79 deployed to Heroku: https://hge-ci-pull-5248.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5248-30ded797

hasura-bot · 2020-07-20T08:06:23Z

Review app for commit 67bd1c1 deployed to Heroku: https://hge-ci-pull-5248.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5248-67bd1c1d

hasura-bot · 2020-08-12T09:02:34Z

Review app for commit 6dc6490 deployed to Heroku: https://hge-ci-pull-5248.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5248-6dc64900

rikinsk

UX approved

hasura-bot · 2020-08-21T13:17:49Z

Review app for commit 6ec474f deployed to Heroku: https://hge-ci-pull-5248.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5248-6ec474fd

hasura-bot · 2020-08-22T10:50:54Z

Review app for commit 7ff057e deployed to Heroku: https://hge-ci-pull-5248.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5248-7ff057ef

tirumaraiselvan · 2020-08-22T11:10:43Z

CHANGELOG.md

@@ -19,6 +19,7 @@ This release contains the [PDV refactor (#4111)](https://github.com/hasura/graph
 - server: some mutations that cannot be performed will no longer be in the schema (for instance, `delete_by_pk` mutations won't be shown to users that do not have select permissions on all primary keys) (#4111)
 - server: miscellaneous description changes (#4111)
 - server: treat the absence of `backend_only` configuration and `backend_only: false` equally (closing #5059) (#4111)
+- console: add user prompt to cascade delete on Postgres dependency errors (close #5109) (#5248)


allow user to cascade Postgres dependencies when dropping Postgres objects

CHANGELOG.md

tirumaraiselvan

changelog

hasura-bot · 2020-08-22T11:35:27Z

Review app for commit d8f5ad8 deployed to Heroku: https://hge-ci-pull-5248.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5248-d8f5ad88

hasura-bot · 2020-08-22T12:07:05Z

Review app https://hge-ci-pull-5248.herokuapp.com is deleted

…stgres objects (close hasura#5109) (hasura#5248)

soorajshankar · 2020-10-01T09:44:36Z

console/src/components/Services/Data/DataActions.js

@@ -689,6 +693,7 @@ const makeMigrationCall = (
                successMsg,
                errorMsg,
                shouldSkipSchemaReload,
+                false,


@beerose Could you please add this change for the very next update?
Related to #5436

pg dependency prompt hasura#5109

41554be

soorajshankar requested a review from a team as a code owner July 1, 2020 08:36

changelog

2827931

soorajshankar requested a review from a team as a code owner July 1, 2020 08:38

soorajshankar assigned beerose Jul 1, 2020

soorajshankar added the c/console Related to console label Jul 1, 2020

soorajshankar assigned soorajshankar and unassigned beerose Jul 1, 2020

soorajshankar assigned beerose Jul 1, 2020

beerose suggested changes Jul 9, 2020

View reviewed changes

console/src/components/Services/Data/utils.js Outdated Show resolved Hide resolved

console/src/components/Services/Data/utils.js Outdated Show resolved Hide resolved

console/src/components/Services/Data/utils.js Show resolved Hide resolved

beerose removed their assignment Jul 12, 2020

soorajshankar and others added 5 commits July 13, 2020 19:24

Update console/src/components/Services/Data/utils.js

fb65a04

Co-authored-by: Aleksandra Sikora <aleksandra@hasura.io>

review comments

0e16ab3

Merge branch 'master' of https://github.com/hasura/graphql-engine int…

8c4d6ef

…o feat/pg_cascade_prompt

Merge branch 'feat/pg_cascade_prompt' of https://github.com/soorajsha…

adc8be5

…nkar/graphql-engine into feat/pg_cascade_prompt

cleanup

30ded79

soorajshankar assigned beerose and unassigned soorajshankar Jul 15, 2020

Merge branch 'master' into feat/pg_cascade_prompt

67bd1c1

beerose changed the title ~~Cascade delete on Postgres dependency errors #5109~~ console: cascade delete on Postgres dependency errors (close #5109) Jul 20, 2020

beerose approved these changes Jul 20, 2020

View reviewed changes

beerose requested a review from rikinsk July 20, 2020 08:35

beerose assigned rikinsk and unassigned beerose Jul 20, 2020

Aleksandra Sikora and others added 2 commits July 20, 2020 10:35

Merge branch 'master' into feat/pg_cascade_prompt

e6654b3

Merge branch 'master' into feat/pg_cascade_prompt

99354d2

soorajshankar and others added 3 commits August 12, 2020 14:03

pg cascade error messaging

6c2c0b9

formating

be9264e

Merge branch 'master' into feat/pg_cascade_prompt

6dc6490

soorajshankar assigned rikinsk and unassigned soorajshankar Aug 12, 2020

split error message across lines

3ed8d1e

rikinsk approved these changes Aug 21, 2020

View reviewed changes

Merge branch 'master' into feat/pg_cascade_prompt

08e3343

rikinsk assigned beerose and unassigned rikinsk Aug 21, 2020

Update CHANGELOG.md

6ec474f

beerose requested a review from tirumaraiselvan August 21, 2020 13:01

Merge branch 'master' into feat/pg_cascade_prompt

7ff057e

beerose removed the request for review from tirumaraiselvan August 22, 2020 10:45

beerose requested a review from tirumaraiselvan August 22, 2020 11:07

tirumaraiselvan reviewed Aug 22, 2020

View reviewed changes

beerose reviewed Aug 22, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

d8f5ad8

tirumaraiselvan approved these changes Aug 22, 2020

View reviewed changes

beerose changed the title ~~console: cascade delete on Postgres dependency errors (close #5109)~~ console: allow user to cascade Postgres dependencies when dropping Postgres objects (close #5109) Aug 22, 2020

beerose merged commit 41f35c6 into hasura:master Aug 22, 2020

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020

console: allow user to cascade Postgres dependencies when dropping Po…

e62d909

…stgres objects (close hasura#5109) (hasura#5248)

soorajshankar linked an issue Sep 30, 2020 that may be closed by this pull request

Removing relationships with dependent objects fails but the console reports success #5436

Closed

soorajshankar commented Oct 1, 2020

View reviewed changes

beerose mentioned this pull request Nov 10, 2020

console: misc fixes #6170

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

console: allow user to cascade Postgres dependencies when dropping Postgres objects (close #5109) #5248

console: allow user to cascade Postgres dependencies when dropping Postgres objects (close #5109) #5248

soorajshankar commented Jul 1, 2020

netlify bot commented Jul 1, 2020 •

edited

hasura-bot commented Jul 1, 2020

hasura-bot commented Jul 15, 2020

hasura-bot commented Jul 20, 2020

hasura-bot commented Aug 12, 2020

rikinsk left a comment

hasura-bot commented Aug 21, 2020

hasura-bot commented Aug 22, 2020

tirumaraiselvan Aug 22, 2020 •

edited

tirumaraiselvan left a comment

hasura-bot commented Aug 22, 2020

hasura-bot commented Aug 22, 2020

soorajshankar Oct 1, 2020

console: allow user to cascade Postgres dependencies when dropping Postgres objects (close #5109) #5248

console: allow user to cascade Postgres dependencies when dropping Postgres objects (close #5109) #5248

Conversation

soorajshankar commented Jul 1, 2020

Description

Changelog

Affected components

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

GraphQL

Breaking changes

netlify bot commented Jul 1, 2020 • edited

hasura-bot commented Jul 1, 2020

hasura-bot commented Jul 15, 2020

hasura-bot commented Jul 20, 2020

hasura-bot commented Aug 12, 2020

rikinsk left a comment

Choose a reason for hiding this comment

hasura-bot commented Aug 21, 2020

hasura-bot commented Aug 22, 2020

tirumaraiselvan Aug 22, 2020 • edited

Choose a reason for hiding this comment

tirumaraiselvan left a comment

Choose a reason for hiding this comment

hasura-bot commented Aug 22, 2020

hasura-bot commented Aug 22, 2020

soorajshankar Oct 1, 2020

Choose a reason for hiding this comment

netlify bot commented Jul 1, 2020 •

edited

tirumaraiselvan Aug 22, 2020 •

edited