Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: show session argument input for computed fields #5610

Closed
wants to merge 49 commits into from
Closed

console: show session argument input for computed fields #5610

wants to merge 49 commits into from

Conversation

kolharsam
Copy link
Contributor

@kolharsam kolharsam commented Aug 18, 2020 •
edited by beerose

closes #5154

Description

This PR mainly adds a new input field for including a session argument for computed fields. This PR also includes minor fixes and also TS migration of the ComputedFieldsEditor file

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Console

Function that you use to test this PR

CREATE OR REPLACE FUNCTION public.get_session_rolezz(result_row text_result, hasura_session json)
 RETURNS SETOF text_result
 LANGUAGE sql
 STABLE
AS $function$
    (SELECT q.* FROM (VALUES (hasura_session ->> 'x-hasura-role')) q)
    UNION ALL
    (SELECT * from text_result)
$function$

Screenshot 2020-11-11 at 19 57 12

@kolharsam kolharsam self-assigned this Aug 18, 2020
@netlify
Copy link

netlify bot commented Aug 18, 2020

Deploy preview for hasura-docs ready!

Built with commit a15c65d

https://deploy-preview-5610--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

Review app for commit 3b872c8 deployed to Heroku: https://hge-ci-pull-5610.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5610-3b872c8b

@netlify
Copy link

netlify bot commented Aug 18, 2020 •
edited

✔️ Deploy preview for hasura-docs ready!

🔨 Explore the source changes: 98df2be

🔍 Inspect the deploy logs: https://app.netlify.com/sites/hasura-docs/deploys/5fca51be7460a6000752789f

😎 Browse the preview: https://deploy-preview-5610--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

Review app for commit eef0aad deployed to Heroku: https://hge-ci-pull-5610.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5610-eef0aadb

@hasura-bot
Copy link
Contributor

Review app for commit eaf7527 deployed to Heroku: https://hge-ci-pull-5610.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5610-eaf7527b

@kolharsam kolharsam marked this pull request as ready for review August 18, 2020 12:25
@kolharsam kolharsam requested review from a team as code owners August 18, 2020 12:25
beerose
beerose suggested changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few, mostly minor, comments.

The functionality looks good.

CHANGELOG.md Outdated Show resolved Hide resolved
console/src/components/Services/ApiExplorer/OneGraphExplorer/OneGraphExplorer.js Outdated Show resolved Hide resolved
console/src/components/Services/Data/TableModify/ComputedFieldsEditor.tsx Outdated Show resolved Hide resolved
console/src/components/Services/Data/TableModify/ComputedFieldsEditor.tsx Outdated Show resolved Hide resolved
console/src/components/Services/Data/TableModify/ComputedFieldsEditor.tsx Outdated Show resolved Hide resolved
console/src/components/Services/Data/TableModify/ComputedFieldsEditor.tsx Outdated Show resolved Hide resolved
console/src/components/Services/Data/TableModify/ComputedFieldsEditor.tsx Outdated Show resolved Hide resolved
console/src/components/Services/Data/TableModify/ComputedFieldsEditor.tsx Outdated Show resolved Hide resolved
console/src/components/Services/Data/Schema/Schema.js Outdated Show resolved Hide resolved
console/src/components/Services/Data/TableModify/ModifyTable.js Outdated Show resolved Hide resolved
@beerose beerose assigned kolharsam and unassigned beerose Oct 16, 2020
@kolharsam kolharsam assigned beerose and unassigned kolharsam Oct 19, 2020
@beerose beerose self-requested a review October 19, 2020 10:39
@beerose beerose self-requested a review November 12, 2020 12:07
beerose
beerose approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console

hasura-bot added a commit that referenced this pull request Jan 28, 2021
@hasura-bot @kolharsam
console: add session argument input for computed fields (close #5154)
1fb92b8 
Co-authored-by: Sameer Kolhar <sameer@hasura.io>
Co-authored-by: Sameer Kolhar <kolhar730@gmail.com>
GITHUB_PR_NUMBER: 5610
GITHUB_PR_URL: #5610

Co-authored-by: Sameer Kolhar <sameer@hasura.io>
Co-authored-by: Sameer Kolhar <kolhar730@gmail.com>
GitOrigin-RevId: 84d9d54
@hasura-bot hasura-bot closed this Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soorajshankar soorajshankar soorajshankar approved these changes

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

@beerose beerose beerose approved these changes

Assignees

@beerose beerose

Labels
c/console Related to console merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

console: session_argument can be set for computed fields as well
5 participants
@kolharsam @hasura-bot @soorajshankar @tirumaraiselvan @beerose