Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: data sources support #5654

Closed
wants to merge 237 commits into from
Closed

console: data sources support #5654

wants to merge 237 commits into from

Conversation

beerose
Copy link
Contributor

@beerose beerose commented Aug 24, 2020 •
edited
Loading

Description

Todo:

  • data/utils
  • data/actions
  • data/constants
  • pgInfo
  • data/add
  • rawSql/utils
  • sqlUtils

Metadata separation:

  • 1. Fetching actions
  • 2. Fetching custom types
  • 3. Custom functions
  • 4. Custom functions definitions
  • 5. Tracked functions
  • 6. Trackable functions
  • 7. Non trackable functions
  • 8. Allowed queries
  • 9. Fetching roles
  • 10. Remote schemas:
  • 11. Remote relationships
  • 12. Fetching console opts from hdb_version. ← new api
  • 13. Tracked tables: hdb_table
  • 14. Tracked table relationships
  • 15. Events

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Console

@rakeshkky
Merge branch 'master' into metadata-separation
1ae53ce 
Resolve Conflicts:
	server/graphql-engine.cabal
	server/src-lib/Hasura/GraphQL/Schema/Action.hs
	server/src-lib/Hasura/RQL/DDL/EventTrigger.hs
	server/src-lib/Hasura/RQL/DDL/Metadata.hs
	server/src-lib/Hasura/RQL/DDL/Metadata/Generator.hs
	server/src-lib/Hasura/RQL/DDL/Metadata/Types.hs
	server/src-lib/Hasura/RQL/DDL/Permission.hs
	server/src-lib/Hasura/RQL/DDL/RemoteRelationship.hs
	server/src-lib/Hasura/RQL/DDL/RemoteSchema.hs
	server/src-lib/Hasura/RQL/DDL/Schema/Cache.hs
	server/src-lib/Hasura/RQL/DDL/Schema/Cache/Fields.hs
	server/src-lib/Hasura/RQL/DDL/Schema/Rename.hs
	server/src-lib/Hasura/RQL/DDL/Schema/Table.hs
	server/src-lib/Hasura/RQL/Types/Action.hs
	server/src-lib/Hasura/RQL/Types/RemoteRelationship.hs
	server/src-lib/Hasura/Server/App.hs
@rakeshkky
wip: draft migration to metadata separation
5344120
@netlify
Copy link

netlify bot commented Aug 26, 2020

Deploy preview for hasura-docs ready!

Built with commit f294195

https://deploy-preview-5654--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

Review app for commit 0bf4565 deployed to Heroku: https://hge-ci-pull-5654.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5654-0bf4565f

@hasura-bot
Copy link
Contributor

Review app for commit 0f4f6bd deployed to Heroku: https://hge-ci-pull-5654.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5654-0f4f6bd3

@hasura-bot
Copy link
Contributor

Review app for commit c25d67f deployed to Heroku: https://hge-ci-pull-5654.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5654-c25d67f7

@hasura-bot
Copy link
Contributor

Review app for commit e286263 deployed to Heroku: https://hge-ci-pull-5654.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5654-e2862630

@netlify
Copy link

netlify bot commented Aug 27, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit c9b41bc

https://deploy-preview-5654--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

Review app for commit 14a5916 deployed to Heroku: https://hge-ci-pull-5654.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5654-14a59164

@hasura-bot
Copy link
Contributor

Review app for commit e9a3257 deployed to Heroku: https://hge-ci-pull-5654.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5654-e9a32572

@hasura-bot
Copy link
Contributor

Review app for commit 86e2463 deployed to Heroku: https://hge-ci-pull-5654.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5654-86e24634

@hasura-bot
Copy link
Contributor

Review app for commit 2b879cd deployed to Heroku: https://hge-ci-pull-5654.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5654-2b879cd1

@hasura-bot
Copy link
Contributor

Review app for commit b1a19f3 deployed to Heroku: https://hge-ci-pull-5654.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5654-b1a19f3a

@hasura-bot
Copy link
Contributor

Review app for commit 6dc1147 deployed to Heroku: https://hge-ci-pull-5654.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5654-6dc11475

Aleksandra Sikora and others added 25 commits October 13, 2020 12:18
remove usage of metadata v2 type
c2c6081
@kolharsam
console: show logs tables (#36)
f39ba69
minor changes
d299835
Merge branch 'console-data-sources' of github.com:beerose/graphql-eng…
9bb3e1d 
…ine into console-data-sources
@rakeshkky
support /v1/query; pg-client library support tx monad transformer
d4818ff
@rakeshkky
avoid '_pecPool' in 'PGExecCtx' type
0dca1da
source selector on events page
a4b61d1
@rakeshkky
avoid '_pecRunRepeatableRead' in 'PGExecCtx' type
3be5e47
Improve styling of db selector on events page
54b1f80
@rakeshkky
fix bulk queries in `/v1/query'
5401aea
@rakeshkky
implement 'setPreResolvedSource' in haskell test
3c10d35
direct access -- events (#38)
a49b7df
require source
ca033ad
@ecthiender
add getDatabaseUid to the MonadMetadataStorage typeclass
75cb0cf
@ecthiender
make the listener thread cleanup optional in runHGEServer
9daa52c 
  - there won't be a listener thread always for every runHGEServer
@ecthiender
add getDatabaseUid to wrapped instances
b9e3e8e
@rakeshkky
make --database-url optional & backward compatibility to the same
bc8eb90 
--> Implements hasura#5797 (comment)
@rakeshkky
Merge branch 'master' into metadata-separation-multi-source
0c6c6fb 
Resolve Conflicts:
	server/src-lib/Hasura/App.hs
	server/src-lib/Hasura/Db.hs
	server/src-lib/Hasura/Eventing/EventTrigger.hs
	server/src-lib/Hasura/Eventing/ScheduledTrigger.hs
	server/src-lib/Hasura/GraphQL/Execute/Insert.hs
	server/src-lib/Hasura/GraphQL/Execute/Mutation.hs
	server/src-lib/Hasura/GraphQL/Execute/Prepare.hs
	server/src-lib/Hasura/GraphQL/Execute/Query.hs
	server/src-lib/Hasura/GraphQL/Schema.hs
	server/src-lib/Hasura/GraphQL/Transport/HTTP.hs
	server/src-lib/Hasura/GraphQL/Transport/WebSocket.hs
	server/src-lib/Hasura/RQL/DDL/EventTrigger.hs
	server/src-lib/Hasura/RQL/Types/EventTrigger.hs
	server/src-lib/Hasura/RQL/Types/SchemaCache.hs
	server/src-lib/Hasura/Server/App.hs
Merge branch 'metadata-separation-multi-source' into console-data-sou…
3879815 
…rces
post merge fixes
1e46a77
Merge branch 'console-data-sources' of github.com:beerose/graphql-eng…
7e22a8f 
…ine into console-data-sources
fix events 404
a1f7d20
@kolharsam
add the new queries to console code (#39)
8b8cc73
fix typo
975eb6a
fix docker compose
a30d4a4
beerose
beerose commented Oct 27, 2020
View reviewed changes
console/src/components/App/App.js
Comment on lines +47 to +49
console.log('fetch metadata');
// no sure yet, if this is the best place
// make it being triggered on each metadata update
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log('fetch metadata');
// no sure yet, if this is the best place
// make it being triggered on each metadata update

beerose
beerose commented Oct 27, 2020
View reviewed changes
console/src/components/App/App.js
Comment on lines +68 to +71
// if (!metadata.metadataObject AND logged in) {
// // todo: should be loading state or error message in case of metadata fetch fail
// return null;
// }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// if (!metadata.metadataObject AND logged in) {
// // todo: should be loading state or error message in case of metadata fetch fail
// return null;
// }

@beerose
Copy link
Contributor Author

beerose commented Nov 2, 2020

Closing this PR, because it has server changes from #5797, and as per discussions on slack #5797 will be split into multiple PRs. I'll open a new Pr containing only console changes.

@beerose beerose closed this Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c/console Related to console no-changelog-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@beerose @hasura-bot @rakeshkky @0x777 @kolharsam @soorajshankar @ecthiender