server: Fix fine-grained incremental cache invalidation (fix #3759) #6027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 0ea37ef |
lexi-lambda
force-pushed
the
fix-incremental-dependencies-gh-3759
branch
from
0ea37ef
to
415aaec
Compare
0x777
approved these changes
Oct 20, 2020
v0d1ch
pushed a commit
to v0d1ch/graphql-engine
that referenced
this pull request
Oct 29, 2020
) (hasura#6027) This issue was very tricky to track down, but fortunately easy to fix. The interaction here is subtle enough that it’s difficult to put into English what would go wrong in what circumstances, but the new unit test captures precisely that interaction to ensure it remains fixed.
codingkarthik
pushed a commit
to codingkarthik/graphql-engine
that referenced
this pull request
Nov 12, 2020
) (hasura#6027) This issue was very tricky to track down, but fortunately easy to fix. The interaction here is subtle enough that it’s difficult to put into English what would go wrong in what circumstances, but the new unit test captures precisely that interaction to ensure it remains fixed.
tirumaraiselvan
pushed a commit
that referenced
this pull request
Nov 13, 2020
…6027) This issue was very tricky to track down, but fortunately easy to fix. The interaction here is subtle enough that it’s difficult to put into English what would go wrong in what circumstances, but the new unit test captures precisely that interaction to ensure it remains fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes issue #3759, a long-standing bug which could cause the values of enum tables to not get refreshed even when an explicit reload is triggered by clicking “Reload enum values” in the console or making a
reload_metadataAPI call.Affected components
Related Issues
#3759
Solution and Design
This issue was very tricky to track down, but fortunately easy to fix. The interaction here is subtle enough that it’s difficult to put into English what would go wrong in what circumstances, but the new unit test captures precisely that interaction to ensure it remains fixed.
Server checklist
This PR includes no breaking changes.