Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: multiple sources: generalize LazyTx to LazyTxT #6097

Merged
merged 6 commits into from
Oct 30, 2020
Merged

server: multiple sources: generalize LazyTx to LazyTxT #6097

merged 6 commits into from
Oct 30, 2020

Conversation

abooij
Copy link
Contributor

@abooij abooij commented Oct 29, 2020 •
edited
Loading

Description

This is an incremental PR towards the changeset of #5797. In particular it implements the generalization from a LazyTx data type to a LazyTxT data type.

This is the graphql-engine change corresponding to the change on pg-client-hs.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Server

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No

Metadata

Does this PR add a new Metadata feature?

  • No

GraphQL

  • No new GraphQL schema is generated

Breaking changes

  • No Breaking changes

@abooij abooij requested a review from nicuveo October 29, 2020 13:45
nicuveo
nicuveo reviewed Oct 29, 2020
View reviewed changes
server/cabal.project Show resolved Hide resolved
server/src-lib/Hasura/Backends/Postgres/Connection.hs Outdated Show resolved Hide resolved
server/src-lib/Hasura/Backends/Postgres/Connection.hs Outdated Show resolved Hide resolved
server/src-lib/Hasura/Backends/Postgres/Connection.hs Outdated Show resolved Hide resolved
server/src-lib/Hasura/Backends/Postgres/Connection.hs Show resolved Hide resolved
server/src-lib/Hasura/Backends/Postgres/Connection.hs Show resolved Hide resolved
server/src-lib/Hasura/Prelude.hs Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Oct 30, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit b128d62

https://deploy-preview-6097--hasura-docs.netlify.app

nicuveo
nicuveo approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@nicuveo nicuveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🚢 🇮🇹 !

tirumaraiselvan
tirumaraiselvan approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no changelog required

@kodiakhq kodiakhq bot merged commit 62da89e into hasura:master Oct 30, 2020
scriptonist pushed a commit to scriptonist/graphql-engine that referenced this pull request Nov 8, 2020
@scriptonist
server: multiple sources: generalize LazyTx to LazyTxT (hasura#6097)
e22ddf8 
hasura#6097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicuveo nicuveo nicuveo approved these changes

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

Assignees
No one assigned
Labels
c/server Related to server no-changelog-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abooij @nicuveo @tirumaraiselvan