Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for Caddyfile are inaccurate #7312

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

petrogad
Copy link

@petrogad petrogad commented Jul 28, 2021

Caddyfile has changed their syntax; updated in proposal.

Description

A change to the documentation.

Changelog

no-changelog-required

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code
    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields
    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

Caddyfile has changed their syntax; updated in proposal.
@petrogad petrogad requested a review from a team as a code owner July 28, 2021 11:50
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @petrogad, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented Jul 28, 2021

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Jul 28, 2021

✔️ Deploy Preview for hasura-docs ready!

🔨 Explore the source changes: bce241a

🔍 Inspect the deploy log: https://app.netlify.com/sites/hasura-docs/deploys/616804ba17935e0008e61576

😎 Browse the preview: https://deploy-preview-7312--hasura-docs.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants