Unit and property tests for sampling and type unification #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmoverton
changed the title
hallettj
approved these changes
Mar 21, 2024
| @@ -18,3 +18,6 @@ serde_json = { version = "1.0.113", features = ["raw_value"] } | |||
| thiserror = "1.0.57" | |||
| tokio = { version = "1.36.0", features = ["full"] } | |||
| these = "2.0.0" | |||
|
|
|||
| [dev-dependencies] | |||
| proptest = "1" | |||
Comment on lines
+298
to
+318
| prop_oneof![ | ||
| Just(BsonScalarType::Double), | ||
| Just(BsonScalarType::Decimal), | ||
| Just(BsonScalarType::Int), | ||
| Just(BsonScalarType::Long), | ||
| Just(BsonScalarType::String), | ||
| Just(BsonScalarType::Date), | ||
| Just(BsonScalarType::Timestamp), | ||
| Just(BsonScalarType::BinData), | ||
| Just(BsonScalarType::ObjectId), | ||
| Just(BsonScalarType::Bool), | ||
| Just(BsonScalarType::Null), | ||
| Just(BsonScalarType::Regex), | ||
| Just(BsonScalarType::Javascript), | ||
| Just(BsonScalarType::JavascriptWithScope), | ||
| Just(BsonScalarType::MinKey), | ||
| Just(BsonScalarType::MaxKey), | ||
| Just(BsonScalarType::Undefined), | ||
| Just(BsonScalarType::DbPointer), | ||
| Just(BsonScalarType::Symbol), | ||
| ] |
There was a problem hiding this comment.
There might be a way to avoid writing out all the enum variants since BsonScalarType implements enum_iterator::Sequence. But I don't know how to do that in proptest. Something like,
let n = arb in (0...BsonScalarType.CARDINALITY);
let scalar_type = BsonScalarType::all().nth(n);There was a problem hiding this comment.
I'll look into this another time. Wanted to get this merged so we can tag a build to put in the CLI registry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.