Add /query trace spans and update SDK #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codedmart
changed the title
hallettj
approved these changes
Apr 27, 2024
| }) | ||
| }) | ||
| } | ||
| .instrument(tracing::info_span!("/query", internal.visibility = "user")) |
There was a problem hiding this comment.
Since this instrumentation applies to the effectively the entire function, I think another way to do this would be to modify the #[instrument] annotation on the function. Currently it's configured to only emit traces on errors, but it can be configured to do other things. One thing to watch out for is that using #[instrument] on a function captures argument values unless you opt out - the skip_all option excludes all arguments from the trace.
But this way works just as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add tracing spans and update to the latest SDK
Issue ticket number and link
MDB-131