test query request with one variable set #69
Merged
+389
−259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallettj
commented
Apr 30, 2024
Comment on lines
30
to
46
| #[tokio::test] | ||
| async fn handles_request_with_single_variable_set() -> anyhow::Result<()> { | ||
| assert_yaml_snapshot!({ | ||
| run_connector_query( | ||
| query_request() | ||
| .collection("movies") | ||
| .variables([vec![("id", json!("573a1390f29313caabcd50e5"))]]) | ||
| .query( | ||
| query() | ||
| .predicate(equal(target!("_id"), variable!(id))) | ||
| .fields([field!("title")]), | ||
| ), | ||
| ) | ||
| .await? | ||
| }); | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
This is the new test
Comment on lines
+1
to
+6
| --- | ||
| source: crates/integration-tests/src/tests/remote_relationship.rs | ||
| expression: "{\n run_connector_query(query_request().collection(\"movies\").variables([vec![(\"id\",\n json!(\"573a1390f29313caabcd50e5\"))]]).query(query().predicate(equal(target!(\"_id\"),\n variable!(id))).fields([field!(\"title\")]))).await?\n}" | ||
| --- | ||
| - rows: | ||
| - title: Gertie the Dinosaur |
There was a problem hiding this comment.
This is the snapshot of the result of the new test
dmoverton
approved these changes
Apr 30, 2024
codedmart
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add a test just to make sure this case works. I thought I remembered MongoDB rejecting
$facetstages with only one sub-pipeline, but according to this test that case works just fine in MongoDB versions 5, 6, and 7.This PR expands the integration tests to allow sending a query request directly to a connector, bypassing the engine. It also cleans up some of the test helper code. The test snapshots all needed to be updated because I changed a function name, which changed the expression used to produce snapshot results, and the expression is captured as part of the snapshot file.
Issue ticket number and link
MDB-135