Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use field type in comparison target instead of column type #82

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

dmoverton
Copy link
Collaborator

@dmoverton dmoverton commented Jun 19, 2024

Describe your changes

Fixes a bug where comparison operator lookup for nested field comparisons was using the column type rather than the type of the nested field, resulting in an UnknownComparisonOperator error.

Note: we will need to do the same thing for ordering and aggregates eventually.

Issue ticket number and link

MDB-53

Type

(Select only one. In case of multiple, choose the most appropriate)

  • highlight
  • enhancement
  • bugfix
  • behaviour-change
  • performance-enhancement
  • security-fix

@dmoverton dmoverton requested a review from hallettj June 19, 2024 13:35
Copy link
Collaborator

@hallettj hallettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@dmoverton dmoverton merged commit 436e12f into main Jun 19, 2024
1 check passed
@dmoverton dmoverton deleted the dmoverton/fix/nested_operator_lookup branch June 19, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants