Skip to content

Commit

Permalink
Run all unit tests on CI.
Browse files Browse the repository at this point in the history
We were only running a subset of unit tests on CI.

Instead of trying to list the (growing) package names, let's just filter
out the database tests.

This also updates the snapshots to include the new connection URI
default value, as these tests were failing.
  • Loading branch information
SamirTalwar committed Jun 24, 2024
1 parent 097a4e9 commit 9ddf6c9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
9 changes: 1 addition & 8 deletions .github/workflows/cargo-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,6 @@ jobs:
test-unit:
strategy:
fail-fast: false
matrix:
package:
- query-engine-execution
- query-engine-metadata
- query-engine-sql
- query-engine-translation
- tests-common
name: test unit
runs-on: ubuntu-latest
env:
Expand All @@ -34,7 +27,7 @@ jobs:

- name: run tests
run: |
cargo nextest run --no-fail-fast --release --filter-expr='package(${{ matrix.package }})'
cargo nextest run --no-fail-fast --release --filter-expr='not package(databases-tests)'
env:
RUST_LOG: INFO

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ packagingDefinition:
supportedEnvironmentVariables:
- name: CONNECTION_URI
description: The PostgreSQL connection URI
defaultValue: postgresql://read_only_user:readonlyuser@35.236.11.122:5432/v3-docs-sample-app
commands:
update: hasura-ndc-postgres update
cliPlugin:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ packagingDefinition:
supportedEnvironmentVariables:
- name: CONNECTION_URI
description: The PostgreSQL connection URI
defaultValue: postgresql://read_only_user:readonlyuser@35.236.11.122:5432/v3-docs-sample-app
commands:
update: hasura-ndc-postgres update
cliPlugin:
Expand Down

0 comments on commit 9ddf6c9

Please sign in to comment.