Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I noticed a few extra calls to
.clone()
while working on an unrelated refactor. I want to remove them for brevity and simplicity; I don't expect a performance improvement.This turns on the Clippy warning
redundant_clone
, which detects unnecessary calls to.clone()
(and.to_string()
).It is an unstable warning and so might reports some false positives. If we find any, we can suppress the warning there.
How
I turned the warning on and applied fixes everywhere.
I also saw a few that the lint didn't catch, which I fixed myself.