Use 'findOne' instead of 'find' for mongoose models.

Replace 'find' with 'findOne' for refactoring issue.
hatashiro · Nov 13, 2012 · 56d5867 · 56d5867
1 parent b1ef429
commit 56d5867
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/server/handlers.js b/server/handlers.js
@@ -14,12 +14,8 @@ function Handlers(web) {
 
     this.channel = {
         get: function(req, res) {
-            ChannelModel.find({name: req.params.name}, function(err, docs) {
-                var channel = null;
-                if(docs.length) {
-                    channel = docs[0];
-                }
-                else {
+            ChannelModel.findOne({name: req.params.name}, function(err, channel) {
+                if (channel === null) {
                     // create new channel
                     channel = new ChannelModel({name: req.params.name, pictures: []});
                     channel.save();

diff --git a/server/socket.js b/server/socket.js
@@ -38,12 +38,8 @@ function Socket(web) {
                 user.join(channels[data.channel]);
             }
             else {
-                ChannelModel.find({name: data.channel}, function(err, channel_results) {
-                    var channel = null;
-                    if(channel_results.length) {
-                        channel = channel_results[0];
-                    }
-                    else {
+                ChannelModel.findOne({name: data.channel}, function(err, channel) {
+                    if(channel === null) {
                         // create new
                         channel = new ChannelModel({name: data.channel, pictures: []});
                         channel.save();