Update esm-outline.md #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think we should use state as it's a requested changeset. State implies it has knowledge of current state. I'm not sure deploy is the right command to add a change request. That would seem to be the final function when the user hits deploy button? What do you think about adding callbacks from the ECM when you add a call. So the inspector that adds a config change can use callbacks to get notified when the changes are applied? What about triggering events on the add/remove/commit methods so that we can watch them for changes, say from the deployer bar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we should use state as it's a requested changeset. State implies it has knowledge of current state.
I'm not sure deploy is the right command to add a change request. That would seem to be the final function when the user hits deploy button?
What do you think about adding callbacks from the ECM when you add a call. So the inspector that adds a config change can use callbacks to get notified when the changes are applied?
What about triggering events on the add/remove/commit methods so that we can watch them for changes, say from the deployer bar?