Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing: do not require messing with hosts file #4

Closed
steebchen opened this issue Dec 18, 2023 · 1 comment · Fixed by #8
Closed

Contributing: do not require messing with hosts file #4

steebchen opened this issue Dec 18, 2023 · 1 comment · Fixed by #8
Assignees
@steebchen

Comments

@steebchen
Copy link
Member 

127.0.0.1 app.dev.hatchet-tools.com

We can just set this as an actual DNS entry I think
@steebchen steebchen assigned steebchen and unassigned steebchen Dec 18, 2023
@steebchen steebchen mentioned this issue Dec 18, 2023
Open
@abelanger5
Copy link
Contributor

Sure, done:

nslookup app.dev.hatchet-tools.com
Non-authoritative answer:
Name:   app.dev.hatchet-tools.com
Address: 127.0.0.1

Took a quick look at any security issues this may cause, only one that seemed relevant is same-site scripting but this seems like it involves domain spoofing and only seems relevant if someone is able to run a webserver on your network.

@steebchen steebchen self-assigned this Dec 19, 2023
@steebchen steebchen linked a pull request Dec 19, 2023 that will close this issue
chore(contributing): remove hosts instruction, do not start studio #8
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steebchen steebchen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(contributing): remove hosts instruction, do not start studio hatchet-dev/hatchet
2 participants
@steebchen @abelanger5