feat(security): multiple encryption options, API tokens, easier setup #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abelanger5
commented
Jan 26, 2024
grutt
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following features:
Encryption options using the Tink cryptographic library.
a. Local master key passed in as an environment variable. This can be generated via
hatchet-admin keyset create-master.b. CloudKMS-backed master key. This can be generated on CloudKMS by following the instructions in
CONTRIBUTING.md.c. Local JWT signing and verification keys can be generated via
hatchet-admin keyset create-local-jwt(unencrypted and passed in as env var) orhatchet-admin keyset create-cloudkms-jwt(encrypted and passed in as env var).API tokens which can be generated from the settings page in the platform. They should be used by SDKs by setting
HATCHET_CLIENT_TOKEN.More docs to come.