Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine): standalone tests and engine teardown #172

Merged
merged 23 commits into from
Feb 27, 2024

Conversation

steebchen
Copy link
Member

@steebchen steebchen commented Feb 18, 2024

Description

Runs load tests in a separate CI action and runs the engine from within the tests. Also adds proper engine teardown functions.

Type of change

Please delete options that are not relevant.

  • Test suite

What's Changed

  • run load tests separately
  • run the engine from inside the test
  • tear down engine in the correct order via cleanup functions
  • eliminate all goroutine leaks

Copy link

gitguardian bot commented Feb 18, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

vercel bot commented Feb 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hatchet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 0:20am

- run load tests separately
- run the engine from inside the test
@steebchen steebchen merged commit ae48410 into main Feb 27, 2024
18 checks passed
@steebchen steebchen deleted the test/load-standalone branch February 27, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add proper teardown functions for engine
2 participants