Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: worker stream state #514

Merged
merged 2 commits into from
May 21, 2024
Merged

fix: worker stream state #514

merged 2 commits into from
May 21, 2024

Conversation

grutt
Copy link
Contributor

@grutt grutt commented May 20, 2024

Description

Fixes the case where a grpc stream is disrupted but heartbeats are still received.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

What's Changed

  • adds an isActive flag to the worker record to
  • filters all valid_workers by is active to ensure that
  • if the grpc stream is not active, we reject heartbeats
  • reassign work to valid workers if it is stuck in the assigned state

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hatchet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 6:43pm

@grutt grutt marked this pull request as ready for review May 21, 2024 14:07
@grutt grutt requested a review from abelanger5 May 21, 2024 14:07
@abelanger5 abelanger5 merged commit eba6ab7 into main May 21, 2024
19 checks passed
@abelanger5 abelanger5 deleted the fix--worker-stream-state branch May 21, 2024 14:29
@grutt grutt mentioned this pull request May 21, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants