fix(worker): deprecate On in favor of RegisterWorkflow #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
steebchen
force-pushed
the
feat/worker-register
branch
from
4af1102
to
4c8c7e7
Compare
steebchen
force-pushed
the
feat/worker-register
branch
from
4c8c7e7
to
8292104
Compare
steebchen
force-pushed
the
feat/worker-register
branch
from
8292104
to
745e401
Compare
steebchen
commented
Jun 21, 2024
pkg/worker/worker.go
Outdated
| @@ -213,6 +213,14 @@ func (w *Worker) NewService(name string) *Service { | |||
| return svc | |||
| } | |||
|
|
|||
| func (w *Worker) RegisterWorkflow(workflow workflowConverter) error { | |||
| wf, ok := workflow.(*WorkflowJob) | |||
There was a problem hiding this comment.
seems like of the possible values of workflowConverter only WorkflowJob can have triggers
abelanger5
approved these changes
Jun 24, 2024
steebchen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
What's Changed