Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(random): refactor random string generation #633

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

steebchen
Copy link
Member

@steebchen steebchen commented Jun 24, 2024

Description

Refactor random string generation

Type of change

  • Refactor (non-breaking changes to code which doesn't change any behaviour)

What's Changed

  • move method to new random package
  • rename GenerateToRandomBytes to GenerateRandomString
  • use specific characters for random string
  • add tests

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hatchet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 8:58pm

@steebchen steebchen changed the title feat(random): refactor random string generation refactor(random): refactor random string generation Jun 24, 2024
- move method to new random package
- rename GenerateToRandomBytes to GenerateRandomString
- use specific characters for random string
- add tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just note, we're removing this file in #631

@steebchen steebchen merged commit b6dcb4e into main Jun 24, 2024
25 checks passed
@steebchen steebchen deleted the feat/random branch June 24, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants