fix: batched reassign and requeue #701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
grutt
commented
Jul 8, 2024
|
|
||
| stepRunId := sqlchelpers.UUIDToStr(stepRunCp.StepRun.ID) | ||
| // wrap in func to avoid leaking spans |
There was a problem hiding this comment.
im not sure if this is needed
grutt
commented
Jul 8, 2024
| g.Go(func() error { | ||
| ctx, span := telemetry.NewSpan(ctx, "handle-step-run-requeue-step-run") | ||
| defer span.End() | ||
| scheduleCtx, cancel := context.WithTimeout(ctx, 1*time.Second) |
There was a problem hiding this comment.
not sure about this. it should be fine considering requeueAfter is set to now + 4s and initial context takes up 1 second and sets sr into a state so they should not be re-re-assigned. but writing 100 sr updates maybe shouldnt take more than 1s?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses db load under high throughput
Type of change
What's Changed