feat: soft delete #717
Merged
feat: soft delete #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abelanger5
reviewed
Jul 16, 2024
abelanger5
reviewed
Jul 17, 2024
| } | ||
|
|
||
| model GetGroupKeyRun { | ||
| // base fields | ||
| id String @id @unique @default(uuid()) @db.Uuid | ||
| createdAt DateTime @default(now()) | ||
| updatedAt DateTime @default(now()) @updatedAt | ||
| deletedAt DateTime? | ||
| deletedAt DateTime? // TODO verify we're setting this |
abelanger5
approved these changes
Jul 18, 2024
| @@ -37,7 +37,7 @@ type ServerConfigFile struct { | |||
|
|
|||
| MessageQueue MessageQueueConfigFile `mapstructure:"msgQueue" json:"msgQueue,omitempty"` | |||
|
|
|||
| Services []string `mapstructure:"services" json:"services,omitempty" default:"[\"health\", \"ticker\", \"grpc\", \"eventscontroller\", \"queue\", \"webhookscontroller\", \"heartbeater\"]"` | |||
| Services []string `mapstructure:"services" json:"services,omitempty" default:"[\"health\", \"ticker\", \"grpc\", \"eventscontroller\", \"queue\", \"webhookscontroller\", \"heartbeater\", \"retention\"]"` | |||
There was a problem hiding this comment.
As a heads up, this is not going to be enabled for existing installations that have a generated config file (via docker compose). We should support regenerating the config file with changes like this eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the delete strategy from hard to soft delete for relations with deep cascades
Type of change