try to fix

hatchet · Apr 24, 2024 · 471aee4 · 471aee4
1 parent 943e265
commit 471aee4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/hatchet/readers/hpctoolkit_v4_reader.py b/hatchet/readers/hpctoolkit_v4_reader.py
@@ -1607,6 +1607,7 @@ def __read_profiles(
             )
 
         # remove the visited profiles.
+        # TODO: remove this code when sparse output format is the default
         if not self.sparse_format:
             not_visited_profiles = [
                 i

diff --git a/hatchet/tests/hpctoolkit.py b/hatchet/tests/hpctoolkit.py
@@ -62,9 +62,9 @@
 ]
 
 
-def test_graphframe(data_dir, calc_pi_hpct_db, sparse_format):
+def test_graphframe(data_dir, calc_pi_hpct_db):
     """Sanity test a GraphFrame object with known data."""
-    gf = GraphFrame.from_hpctoolkit(str(calc_pi_hpct_db), sparse_format=sparse_format)
+    gf = GraphFrame.from_hpctoolkit(str(calc_pi_hpct_db))
 
     assert len(gf.dataframe.groupby("module")) == 5
     assert len(gf.dataframe.groupby("file")) == 11
@@ -237,9 +237,9 @@ def test_inclusive_time_calculation(data_dir, calc_pi_hpct_db):
 
 # TODO: remove False option once sparse is only option in next major release
 @pytest.mark.parametrize("sparse_format", [False, True])
-def test_graphframe_v4(data_dir, calc_pi_hpct_v4_db):
+def test_graphframe_v4(data_dir, calc_pi_hpct_v4_db, sparse_format):
     """Sanity test a GraphFrame object with known data."""
-    gf = GraphFrame.from_hpctoolkit(str(calc_pi_hpct_v4_db))
+    gf = GraphFrame.from_hpctoolkit(str(calc_pi_hpct_v4_db), sparse_format=sparse_format)
     df = gf.dataframe
 
     for col in gf.dataframe.columns: