Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new
gf.save()
API to enable writing out processed graphframes to a file. This can be useful if a user doesn't want to wait for input data to be read in, or wants to save out a resulting graphframe after many operations.One of the challenges here is given that all the readers have different formats, what is the minimum info we want to include in this file, so as not to lose important data?
The current output format I'm proposing is similar to caliper's json file:
So far, I've looked at outputting a literal graphframe and an HPCToolkit graphframe. These are good to compare because it already identifies the differences in the data each reader creates. The nodes are dumped by traversing the graph, outputting the frame attributes, and grabbing the
_hatchet_nid
of the parent.literal:
HPCToolkit: