Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect metric readings in hpctoolkit reader v4 #546

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix incorrect metric readings in hpctoolkit reader v4 #546

wants to merge 2 commits into from

Conversation

ocnkr
Copy link
Collaborator

@ocnkr ocnkr commented May 24, 2024

This PR fixes the incorrect metric values when there are multiple metrics.

Two main changes for this fix:

  1. It was overwriting the visited profiles, so I fixed the handling of the visited and non-visited profiles.
  2. I fixed the calculation and reading of metric value boundaries in profile data.

@ocnkr ocnkr added type: bug Identifies bugs in issues and identifies bug fixes in PRs status: ready for review This PR is ready to be reviewed by assigned reviewers priority: high High priority issues and PRs area: readers PRs and Issues involving Hatchet's data readers labels May 24, 2024
@ocnkr ocnkr requested review from bhatele and lithomas1 May 24, 2024 17:31
@ocnkr ocnkr self-assigned this May 24, 2024
@bhatele bhatele mentioned this pull request May 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhatele bhatele Awaiting requested review from bhatele

@lithomas1 lithomas1 Awaiting requested review from lithomas1

At least 1 approving review is required to merge this pull request.

Assignees

@ocnkr ocnkr

Labels
area: readers PRs and Issues involving Hatchet's data readers priority: high High priority issues and PRs status: ready for review This PR is ready to be reviewed by assigned reviewers type: bug Identifies bugs in issues and identifies bug fixes in PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ocnkr