Skip to content

Commit

Permalink
fix(console): fix changed variable names
Browse files Browse the repository at this point in the history
  • Loading branch information
hatemhosny committed Jan 30, 2021
1 parent 483bf08 commit c514815
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 4 deletions.
10 changes: 10 additions & 0 deletions src/localpen/assets/localpen.css
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,20 @@ body {
}
#console {
overflow: auto;
background-color: #efefef;
}
#console .luna-object-viewer {
overflow: hidden;
}
#console .luna-console-error {
z-index: 40;
}
#console pre.luna-console-code {
visibility: hidden;
}
#console pre.luna-console-code.visible {
visibility: visible;
}
#console-input-indicator {
color: rgb(64, 169, 243);
padding-top: 2px;
Expand Down
19 changes: 19 additions & 0 deletions src/localpen/console.ts
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,10 @@ export const createConsole = (
) {
return;
}

const message = event.data;
const api = [
'output',
'log',
'error',
'info',
Expand All @@ -254,6 +256,7 @@ export const createConsole = (
);
}
});

return consoleEmulator;
};

Expand Down Expand Up @@ -293,6 +296,11 @@ export const createConsole = (
addKeyBinding('exec', monaco.KeyCode.Enter, () => {
const command = editor.getValue();
const iframe = document.querySelector(sourceSelector) as HTMLIFrameElement;
consoleEmulator.insert({
type: 'input',
args: [command],
ignoreFilter: true,
});
iframe.contentWindow?.postMessage({ console: command }, '*');
commands.push(command);
editor.getModel().setValue('');
Expand Down Expand Up @@ -320,6 +328,17 @@ export const createConsole = (
editorOptions.container.style.height = height + 'px';
});

// workaround to remove 'luna-console-' in variable names in console output
const observer = new MutationObserver(() => {
const newLogs = consoleElement.querySelectorAll('pre.luna-console-code:not(.visible)');
if (newLogs.length === 0) return;
newLogs.forEach((log) => {
log.innerHTML = log.innerHTML.replace(/luna-console-/, '');
log.classList.add('visible');
});
});
observer.observe(consoleElement, { subtree: true, childList: true });

const margin = document.querySelector('#console-input .glyph-margin') as HTMLElement;
const indicator = document.createElement('div') as HTMLElement;
indicator.id = 'console-input-indicator';
Expand Down
9 changes: 5 additions & 4 deletions src/localpen/result-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,10 @@ window.addEventListener('error', (error) => {

window.addEventListener('message', (event) => {
if (event.origin.startsWith(location.origin) && event.data.console) {
// eslint-disable-next-line
console.log('>', event.data.console);
// eslint-disable-next-line
console.log('<', eval(event.data.console));
parent.postMessage(
// eslint-disable-next-line
{ type: 'console', method: 'output', args: getString([eval(event.data.console)]) },
'*',
);
}
});

0 comments on commit c514815

Please sign in to comment.