Fix dcd_set_address bug when called more than once #1021
Conversation
addresses (e.g. after plugging the device into a different port).
There was a problem hiding this comment.
Yeah, right, this is spot-on, it may be related to several other issues with unplug/re-plug stm32 (may solve issue #179). Though I think we should also clear the DAD within the bus_reset() as well to make it consistent. Since it is an easy change, I have already push the commit to your fork. Thank you for the fix.
|
Thanks for the merge! I did notice several more places that looked very suspicious. I plan to go though it from top to bottom, but it may take a while before I get to it as I have a big deadline coming up. |
|
I am the one to say thank, looking forward to your PRs |
|
Oops, this was my bad. It's been there since the beginning. Thanks @tringis for finding this :)! |
No worry, I have tons of bug all over the places as well 😅😅 |
Describe the PR
dcd_set_address() is broken when called more than once, e.g. when plugging in the device into a different port. The problem is that it only sets new bits in the register, it doesn't clear any. Setting addres 1 followed by address 2 therefore causes the address to be set to (1|2) = 3.