msp430x5xx: Set base of transmit_packet buffer earlier to avoid incre… #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…menting past unsent data.
hathach
approved these changes
Oct 24, 2021
There was a problem hiding this comment.
Superb ! Thank you for looking at this, this is my bad, I didn't pay attention enough to variable queued_len (got changes).
Yeah, you are right, msp430 does not support ISO transfer. Though the dcd_edpt_xfer_fifo()` can still be useful, it allows the driver such as cdc to interact directly using fifo rather than an continuous linear buffer as a middle-man. I haven't got time to make use of that, but we could optimize that later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…menting past unsent data. Closes #1105.
FWIW, I found this via a bisect; commit a5d7b62 introduced the breaking change. MSP430 USB doesn't support iso xfers, so I'm not sure if that code should even be in there, but since it's commented out, I'll leave it alone for now.