Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dcd_esp32sx with correct include list #1164

Merged
merged 1 commit into from Nov 1, 2021
Merged

update dcd_esp32sx with correct include list #1164

merged 1 commit into from Nov 1, 2021

Conversation

suda-morris
Copy link
Contributor

Describe the PR
A tiny minor update. dcd_esp32sx.c doesn't use any APIs in periph_ctrl.h but the USB interrupt source number listed in soc/periph_defs.h.

@suda-morris
Copy link
Contributor Author

Hi @hathach Will you consider this quick MR? Some API like periph_ctrl.h is going to be private, thus the including path will slightly change in the future. This MR can make the DCD driver stay work.

hathach
hathach approved these changes Nov 1, 2021
View reviewed changes
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good. thank you for the pr.

@hathach hathach merged commit 9245b8f into hathach:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hathach hathach hathach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suda-morris @hathach