Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused-parameter errors when LOGGER=swo #1222

Merged
merged 1 commit into from Dec 7, 2021

Conversation

scoudreau
Copy link
Contributor

Describe the PR
Remove errors when compiling with LOGGER=swo.
All arguments of sys_read() must be used in function, otherwise it triggers "unused-parameter" errors.

Additional context
Before this patch, error was:

hw/bsp/board.c: In function '_read':
hw/bsp/board.c:126:44: error: unused parameter 'buf' [-Werror=unused-parameter]
126 | TU_ATTR_USED int sys_read (int fhdl, char *buf, size_t count)
| ~~~~~~^~~
compilation terminated due to -Wfatal-errors.
cc1: all warnings being treated as errors

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right, thank you for your PR. I was planning to add the SWO read, but then I realize swo is output only :D and kind of forgot to fix this.

@hathach hathach merged commit cde824f into hathach:master Dec 7, 2021
@scoudreau scoudreau deleted the swo_logger branch December 8, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants