Add HCD driver for Renesas RX #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
amazing, thank you again for another PR. I will check it out as soon as I could. |
hathach
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Thank you very much for this excellent PR and sorry for the huge delay in response. I have been lagging behind due to overwhelming work. The PR look great
hcd_port_reset() has a busy loop to assert USB reset signaling during 10-20ms. I think it is not a good way. I guess after hcd_port_reset_end() is implemented, refactor these implementation.
indeed the port reset with blocking delay is not ideal. It is better with RTOS thanks to scheduler but totally not great with non-OS. We will find another way to implement this later on. Host stack is still lagging behind device one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Add a HCD driver for Renesas RX
Additional context
I have checked
cdc_msc_hidworks on Renesas RX65N Target Board. It is tested with a low speed mouse and a Raspberry Pi Pico running as Mass Storage. If you check the example works on the board, short-circuit betweenJP1-3and VBUS to supply 5V power.Because Renesas RX65N Target Board has no an external power supply IC like as described user's manual shown below. So, we need to supply 5V power to VBUS from a something source.
hcd_port_reset()has a busy loop to assert USB reset signaling during 10-20ms. I think it is not a good way. I guess afterhcd_port_reset_end()is implemented, refactor these implementation.