Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in TUD_AUDIO_HEADSET_STEREO_DESCRIPTOR, _nitfs should be 3. #1360

Merged
merged 1 commit into from Mar 9, 2022

Conversation

ccrome
Copy link
Contributor

@ccrome ccrome commented Mar 2, 2022

I believe that there is a mistake in the definition of TUD_AUDIO_HEADSET_STEREO_DESCRIPTOR. The nitfs in the audio descriptor is always 3 regardless of ITF_NUM_TOTAL.

Describe the PR
I change the number of interfaces to 3, so that I could add a CDC descriptor after, and it worked without complaints from Linux.

I believe that there is a mistake in the definition of TUD_AUDIO_HEADSET_STEREO_DESCRIPTOR.  The nitfs in the audio descriptor is always 3 regardless of ITF_NUM_TOTAL.
Copy link
Collaborator

@kasjer kasjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccrome You are right, it should be 3 as this examples clearly has 3 interfaces (control/speaker/microphone). My bad.

@hathach
Copy link
Owner

hathach commented Mar 9, 2022

great work, thank you for your fix

@hathach hathach merged commit 0d8be7f into hathach:master Mar 9, 2022
@ccrome
Copy link
Contributor Author

ccrome commented Mar 11, 2022

You're welcome.... took me a bit to track down when I added a CDC device to my audio device. Thanks for the awesome library and examples!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants