Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stm32wb55 support #1374

Merged
merged 3 commits into from Mar 7, 2022
Merged

stm32wb55 support #1374

merged 3 commits into from Mar 7, 2022

Conversation

kasjer
Copy link
Collaborator

@kasjer kasjer commented Mar 5, 2022

Describe the PR
This PR adds support for STM32WB55 MCU.
nucleo-wb55rg board is also added.

This MCU has stm32_fsdev FS device USB block same as some others ST devices (F1, Gx)

Additional context
ST provided headers have incorrect value of USB_PMAADDR that is used in stm32_fsdev code.
Issue is filed on their github.
So for now this is fixed on TinyUSB side.

@kasjer kasjer changed the title Kasjer/stm32wb55 stm32wb55 support Mar 5, 2022
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is very minor, I think the family name should be stm32wb 55 is too specific. Other than that, everything looks great.

@kasjer
Copy link
Collaborator Author

kasjer commented Mar 7, 2022

It is very minor, I think the family name should be stm32wb 55 is too specific. Other than that, everything looks great.

I agree, let me change it. I used 55 because this is the only part that has USB.

@hathach
Copy link
Owner

hathach commented Mar 7, 2022

It is very minor, I think the family name should be stm32wb 55 is too specific. Other than that, everything looks great.

I agree, let me change it. I used 55 because this is the only part that has USB.

oh I didn't know that, but I guess that could be changed in the future. It is still better to rename it

@kasjer
Copy link
Collaborator Author

kasjer commented Mar 7, 2022

I have not problem with changing family it to WB only.
btw. while you are on it, maybe you can suggest how to set UF2_FAMILY_ID = in make file.
It's new to me, and I did not dwell on the subject really.

@hathach
Copy link
Owner

hathach commented Mar 7, 2022

It is the ID for DFU example with board pre-flashed with uf2 bootloader such as https://github.com/adafruit/tinyuf2 . The ID is managed by uf2 specs, ID for stm32wb is as follows. It is optional, for convenient purpose only. So far most of the board is devkit with dedicated jtag/swd debugger.

https://github.com/microsoft/uf2/blob/f0506988eaf24cc12646ed1a39799fa29b204eed/utils/uf2families.json#L128-L130

@kasjer
Copy link
Collaborator Author

kasjer commented Mar 7, 2022

Family changed to STM32WB.
I also change board name to stm32wb55nucleo to match other nucleo boards naming convention.

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thank you very much for your PR.

@hathach hathach merged commit 1bd31c2 into hathach:master Mar 7, 2022
@kasjer kasjer deleted the kasjer/stm32wb55 branch March 7, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants