cdc: Fix autoflush for FIFO < MPS #1487
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
perigoso
reviewed
Jun 2, 2022
tore-espressif
force-pushed
the
fix/cdc_autoflush
branch
from
7cf5f75
to
bf22f89
Compare
hathach
requested changes
Dec 5, 2022
There was a problem hiding this comment.
sorry for late response, I was too busy with other works. The reason for change request: although it has more code, the additional condition CFG_TUD_CDC_TX_BUFSIZE < BULK_PACKET_SIZE is constant expression and will help the compiler to optimize it out.
Therefore we don't have to run tu_fifo_full() when bufsize is larger than the packet size (and const expression also not executed at all in other case)
tore-espressif
force-pushed
the
fix/cdc_autoflush
branch
from
bf22f89
to
603effb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
If CDC TX buffer size is configured to be less than bulk packet size, the autoflushing condition is never reached.
Changes:
Additional context
Found out during espressif/esp-idf#9040