Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub out dcd_edpt_close for samd #1515

Merged
merged 1 commit into from Jun 18, 2022
Merged

Conversation

maddyaby
Copy link
Contributor

Not having this prevents the device from finishing the mounting process.

Tested on a SAMD51 and didn't seem to need to actually do anything in the close function. Did repeated close/opens of an audio streaming endpoint.

Not having this prevents the device from finishing the mounting process.

Tested on a SAMD51 and didn't seem to need to actually do anything in the close function.
@hathach
Copy link
Owner

hathach commented Jun 17, 2022

dcd_edpt_close() is mostly used by audio with ISO endpoint, since SAMD doesn't support/test with ISO, it is left out. Have you manage to get audio example running with samd51 ?

@maddyaby
Copy link
Contributor Author

I got a streaming application working with SAMD51 (audio streaming from computer to device using ISO OUT endpoint). I needed to stub this out though for the calls in audio_device.c / audiod_set_interface to finish correctly.

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for testing out, samd is not tested with ISO yet. Though indeed, this will allow it to enumerate and do a bit more testing.

@hathach hathach merged commit ae8b8f0 into hathach:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants